Add sound when pv enters alarm state #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nstelter-slac
force-pushed
the
add_sound
branch
from
527a781
to
c1a712a
Compare
|
to try feature: (note: beep will not play if you have "Terminal Bell" disabled in the terminal that launched slam (or possibly if other "system sounds" settings are disabled)) |
added 20 commits
November 13, 2023 15:53
…pv, and pv's alarm is tripped
…ir color updated correctly when enabled/disabled
also add: -add option to use shorthand cmd line args -make annunciate checkbox say "Annunciate (disabled)" to avoid confusion when annunciate disabled from cmd line
…tate and should annunciate
nstelter-slac
force-pushed
the
add_sound
branch
from
5ab926e
to
6286bee
Compare
added 4 commits
November 13, 2023 16:55
Also remove some un-needed annunciate-related test code
jbellister-slac
approved these changes
Nov 21, 2023
| @@ -61,6 +61,7 @@ def __init__( | |||
| topic: str, | |||
| table_type: AlarmTableType, | |||
| plot_slot: Callable, | |||
| annunciate: bool = False, | |||
There was a problem hiding this comment.
not currently used for tables but maybe could be useful in the future
Comment on lines
-11
to
+22
| parser.add_argument("--topics", help="Comma separated list of kafka alarm topics to listen to") | ||
| parser.add_argument("-t", "--topics", help="Comma separated list of kafka alarm topics to listen to") | ||
| parser.add_argument( | ||
| "-b", | ||
| "--bootstrap-servers", | ||
| default="localhost:9092", | ||
| help="Comma separated list of urls for one or more kafka boostrap servers", | ||
| ) | ||
| parser.add_argument("--user-permissions", default="admin", help="One of read-only, operator, admin") | ||
| parser.add_argument("--log", default="warning", help="Logging level. debug, info, warning, error, critical") | ||
| parser.add_argument("-u", "--user-permissions", default="admin", help="One of read-only, operator, admin") | ||
| parser.add_argument("-l", "--log", default="warning", help="Logging level. debug, info, warning, error, critical") | ||
| parser.add_argument( | ||
| "-a", "--annunciate", action="store_true", help="Enable beep from alarms that have annunciate setting enabled" | ||
| ) # default=False |
There was a problem hiding this comment.
thanks for the easier command line options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use print ('\a') to produce cross-platform sound when any alarm enters active-alarm state
also add option for short-hand cmd line args (-a and --annunciate as options)